From ad93f2bc3e0c34c9c07d16ca2a3ac76811605607 Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Thu, 11 Feb 2010 10:38:44 +0200 Subject: [PATCH] widget: don't check before setting to avoid costly type checks There are no side effect of setting these flags and we don't fire g_object notifies also. Thus set/unset right away without costly check of current state. --- gtk/gtkwidget.c | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c index a18fc0c259..953440eb3a 100644 --- a/gtk/gtkwidget.c +++ b/gtk/gtkwidget.c @@ -5986,15 +5986,10 @@ gtk_widget_set_realized (GtkWidget *widget, { g_return_if_fail (GTK_IS_WIDGET (widget)); - realized = realized != FALSE; - - if (realized != gtk_widget_get_realized (widget)) - { - if (realized) - GTK_WIDGET_SET_FLAGS (widget, GTK_REALIZED); - else - GTK_WIDGET_UNSET_FLAGS (widget, GTK_REALIZED); - } + if (realized) + GTK_WIDGET_SET_FLAGS (widget, GTK_REALIZED); + else + GTK_WIDGET_UNSET_FLAGS (widget, GTK_REALIZED); } /** @@ -6033,15 +6028,10 @@ gtk_widget_set_mapped (GtkWidget *widget, { g_return_if_fail (GTK_IS_WIDGET (widget)); - mapped = mapped != FALSE; - - if (mapped != gtk_widget_get_mapped (widget)) - { - if (mapped) - GTK_WIDGET_SET_FLAGS (widget, GTK_MAPPED); - else - GTK_WIDGET_UNSET_FLAGS (widget, GTK_MAPPED); - } + if (mapped) + GTK_WIDGET_SET_FLAGS (widget, GTK_MAPPED); + else + GTK_WIDGET_UNSET_FLAGS (widget, GTK_MAPPED); } /** -- 2.30.2